Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more checksum algorithms #139

Closed
wants to merge 7 commits into from
Closed

Support more checksum algorithms #139

wants to merge 7 commits into from

Conversation

ianling
Copy link
Collaborator

@ianling ianling commented Apr 21, 2022

Depends on and contains commits from #134, #135, #137, and #138

Allows all the known checksum algorithms in the enum to be considered valid.

Fixes #96

Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
Signed-off-by: Ian Ling <ian@iancaling.com>
@jdolitsky
Copy link

Hi, any update on this PR? Just ran into #96 converting a tv doc to JSON:

got unknown checksum type SHA512 

@jdolitsky
Copy link

Can confirm this PR fixes the error related to SHA512

@ianling
Copy link
Collaborator Author

ianling commented Jun 7, 2022

@jdolitsky there are a couple more PRs in the pipeline ahead of this one, but we'll get to it! Sorry for the delay.

@jdolitsky
Copy link

appreciate the update @ianling !

@lumjjb lumjjb added this to the 0.4.0 milestone Aug 26, 2022
@lumjjb
Copy link
Collaborator

lumjjb commented Oct 21, 2022

Hi @ianling just checking in back on this!

@lumjjb
Copy link
Collaborator

lumjjb commented Jan 4, 2023

This has been resolved by #173

@lumjjb lumjjb closed this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tvloader] got unknown checksum type SHA512
3 participants