Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #6 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for issue #6 #7

wants to merge 1 commit into from

Conversation

Tallyrald
Copy link

The fix comes from this post in the redhat bugzilla.

WARNING: I do not know if these changes have any side affects. This PR is mostly for documentation purposes.

@Tallyrald
Copy link
Author

After diving deeper I found the following:
Since NodeJS changed the onStreamRead function (in this commit, look for the lib/internal/stream_base_commons.js modified file), the currently used uv indicators (UV_EOF & UV_ECONNRESET can no longer be used since the new function only takes an array buffer as parameter.

As a result my first commit in this PR passes a valid array buffer to the currently in use onStreamRead function, however this also means that all previous versions of Node break - hence the Travis fails.

I think the two possible solutions would be:

  1. Detect Node version and apply correct usage
  2. Apply some kind of fix for the new Node approach and create a new major version for handle-thing (indicating the breaking change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant