Avoid using deprecated process.binding('http_parser') #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to a sub-issue in spdy-http2/node-spdy#380 |
lamweili
changed the title
lamweili
changed the title
|
Any movement on this PR? |
|
/cc @indutny Can you review this? Will be great to fix deprecation issue |
ILOveyouo
approved these changes
Dec 10, 2021
|
Folks, it's been 6 months, and http-deceiver's dep warning here on Node >= 10 causes warnings across the board (spdy, hence restify etc.). We have a working PR, what gives? @indutny I understand you've got a full gynormous plate, but this would really help :) |
|
Any chance to get this merged? I'd be happy to help. |
|
Any news? it's been a while now! |
|
waiting for this to be merged hehe |
sternam
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
@daviddias Looks good to me. Could you please merge it or give me write privileges I'd be happy to do it 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Refs: https://nodejs.org/api/deprecations.html#DEP0111