New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom style for each calendar event #1246
base: main
Are you sure you want to change the base?
Add custom style for each calendar event #1246
Conversation
Hi @patriksvensson, I'm sorry, but I'm new to GitHub contributions.
I apologize if this is not the correct way, or if you have already been notified about these 3 PRs and you will be checking them in the future. I just wanted to make sure to bring them to your attention. |
@davide-pi Hello, yes we do not automatically assign reviewers to PRs. We do things as we have time. Right now we鈥檙e all on summer vacation so work on this project will be at a minimum. We work on this project in our spare time and we all have jobs and families so there isn鈥檛 really an SLA. Someone will get around to reviewing this at some point. I will try to set aside some time next week. |
Thanks for explaining. I will wait for a review when someone of you has time. Thanks again. |
I haven't seen this pull request and therefore created #1254... :D The benefit of this here is that there's still the option to specify a default highlight color for the whole calendar while mine doesn't allow that (In my case that was ok, as I don't need the option either way). |
This one would be really nice and I guess is neither breaking nor difficult to verify that it works... |
@patriksvensson Can we get this into the next release, please? (At the moment, I maintain a custom fork of the project to use the feature...) 馃槄 |
Description
Implemented the custom highlight style for single calendar event.
Also requested with issue #1234.
Example
As shown below the calendar now support the default highlight style
2023-06-22
but also support different style for different events like2023-06-24
and2023-06-25
in yellow foreground and2023-06-27
with red foregroundTo Test
To test this implementation is sufficient to put it into the
Main
method of theProgram.cs
in theSpectre.Console.Analyzer.Sandbox
.Please upvote 馃憤 this pull request if you are interested in it.