Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #1390 #1514

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

BlazeFace
Copy link
Contributor

@BlazeFace BlazeFace commented Apr 14, 2024

fixes #1390

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Updated the ratio calculation to round up if the remainder is within 0.9999 I have tested this with a good amount of examples and it still works, but I have not written any proof that this will remain correct at any value. We could use a much smaller target to round say .99 as well.


Please upvote 馃憤 this pull request if you are interested in it.

@BlazeFace
Copy link
Contributor Author

@patriksvensson The only major modification I was considering was a bounds check to see if the total height could go over the target, do you think that is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel in layout adds newline in more complex layout split
1 participant