fix: only devDependencies are installed regardless of the node env, fix

pnpm#4745
spencer17x · May 26, 2022 · 9146f8d · 9146f8d
1 parent 95ac386
commit 9146f8d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/config/src/index.ts b/packages/config/src/index.ts
@@ -338,6 +338,15 @@ export default async (
 
   pnpmConfig.packageManager = packageManager
 
+  if (env.NODE_ENV) {
+    if (cliOptions.production) {
+      pnpmConfig.only = 'production'
+    }
+    if (cliOptions.dev) {
+      pnpmConfig.only = 'dev'
+    }
+  }
+
   if (pnpmConfig.only === 'prod' || pnpmConfig.only === 'production' || !pnpmConfig.only && pnpmConfig.production) {
     pnpmConfig.production = true
     pnpmConfig.dev = false

diff --git a/packages/pnpm/test/install/only.ts b/packages/pnpm/test/install/only.ts
@@ -26,6 +26,15 @@ test('production install (with production NODE_ENV)', async () => {
   await project.has('is-positive')
 })
 
+test('dev dependencies install (with production NODE_ENV)', async () => {
+  const project = prepare(basicPackageManifest)
+
+  await execPnpm(['install', '--dev'], { env: { NODE_ENV: 'production' } })
+
+  await project.hasNot(Object.keys(basicPackageManifest.dependencies!)[0])
+  await project.has('@rstacruz/tap-spec')
+})
+
 test('install dev dependencies only', async () => {
   const project = prepare({
     dependencies: {