Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(bash-v2): various cleanups #1702

Merged
merged 6 commits into from Oct 17, 2022
Merged

style(bash-v2): various cleanups #1702

merged 6 commits into from Oct 17, 2022

Commits on Aug 19, 2022

  1. style(bash-v2): use arithmetic evaluation in numeric context

    @scop
    scop committed Aug 19, 2022
    Copy the full SHA
    48a6fe5 View commit details
    Browse the repository at this point in the history

  2. style(bash-v2): remove unnecessary $ from array index variables

    @scop
    scop committed Aug 19, 2022
    Copy the full SHA
    10da1a8 View commit details
    Browse the repository at this point in the history

  3. style(bash-v2): [[ ]] over [ ], == over =, remove unnecessary quoting

    @scop
    scop committed Aug 19, 2022
    Copy the full SHA
    933caf6 View commit details
    Browse the repository at this point in the history

  4. style(bash-v2): use ${foo-} rather than ${foo:-} in emptiness check 

    The result of the expansion is null no matter if the variable is unset
or null in both cases; the former form is arguably easier on the eye.
    @scop
    scop committed Aug 19, 2022
    Copy the full SHA
    966d0a8 View commit details
    Browse the repository at this point in the history

  5. style(bash-v2): remove unnecessary trailing linefeed removal 

    No longer needed as of f464d6c, saves
a subshell.
    @scop
    scop committed Aug 19, 2022
    Copy the full SHA
    aa60170 View commit details
    Browse the repository at this point in the history

  6. style(bash-v2): use herestring in activehelp extraction 

    Herestrings read cleaner than process substitutions, and work in posix
mode (but we do and will have some process substitutions so this doesn't
matter much). Both approaches may end up using temporary files.
    @scop
    scop committed Aug 19, 2022
    Copy the full SHA
    ef504a6 View commit details
    Browse the repository at this point in the history