Always propagate root context to child command

[pietern]

The context passed to the root command should propagate to its children not only on the first execution but also subsequent calls. Calling the same command multiple times is common when testing cobra applications.

[CLAassistant]

All committers have signed the CLA.

[marckhouzam]

Thanks @pietern.
Can you first sign the CLA: #1875 (comment)

[marckhouzam]

I'm worried think this could be a breaking change...
If a program calls ExecuteContext on another command than that command would get a different context on the root if we always pass it down.

I'll be honest that I don't know if this is a valid scenario. But we have to be very careful since Cobra is used by so many programs. I'll have to test to see if there is a potential problem.

[pietern]

I understand what you mean. In fact without other changes executing a subcommand with a context would not have effect and it would use the root's context. The line of code that makes that happen turned out to not be covered by tests:

cobra/command.go

Line 1012 in 9235920

return c.Root().ExecuteC()

I added a test to cover this scenario and changed the line such that a command's context is also passed down to the root if execute was called on a subcommand.

[github-actions]

The Cobra project currently lacks enough contributors to adequately respond to all PRs. This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the PR is closed.
  You can:
• Make a comment to remove the stale label and show your support. The 60 days reset. - If a PR has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interested in reopening.

[pietern]

Not stale.

[libozh]

I had a similar request: #2077 . I think they are trying to cover similar use cases.