Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

args_test refactorization after generalizing ValidArgs #841

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

args_test refactorization after generalizing ValidArgs #841

wants to merge 6 commits into from

Commits on Aug 21, 2022

  1. feat: generalize ValidArgs; use it implicitly with any validator

    @umarcor
    umarcor committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    2cd7871 View commit details
    Browse the repository at this point in the history

  2. command/ValidateArgs: check ValidArgs regardless of Args being nil

    @umarcor
    umarcor committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    78048ea View commit details
    Browse the repository at this point in the history

  3. add expectError helper function to args_test

    @umarcor
    umarcor committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    d4d0679 View commit details
    Browse the repository at this point in the history

  4. args_test: style

    @umarcor
    umarcor committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    d507a44 View commit details
    Browse the repository at this point in the history

  5. args_test: use sub-tests for grouping based on the validator

    @umarcor
    umarcor committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    64d7401 View commit details
    Browse the repository at this point in the history

  6. args_test: add TestArgs_Nil

    @umarcor
    umarcor committed Aug 21, 2022
    Configuration menu
    Copy the full SHA
    a9dbe74 View commit details
    Browse the repository at this point in the history