Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(diff): use arg '--strip-trailing-cr' #949

Merged
merged 1 commit into from Nov 16, 2021
Merged

fix(diff): use arg '--strip-trailing-cr' #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cobra/cmd/golden_test.go
View file
Open in desktop
Expand Up @@ -43,7 +43,7 @@ func compareFiles(pathA, pathB string) error {
// Don't execute diff if it can't be found.
return nil
}
diffCmd := exec.Command(diffPath, "-u", pathA, pathB)
diffCmd := exec.Command(diffPath, "-u", "--strip-trailing-cr", pathA, pathB)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!! Thanks for this! And all the patience

diffCmd.Stdout = output
diffCmd.Stderr = output

Expand Down