Skip to content

Commit

Permalink
ci: enable test shuffle; fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandear authored and sagikazarmark committed Dec 6, 2023
1 parent 73dfb94 commit 3a23b80
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
Expand Up @@ -57,11 +57,11 @@ jobs:
go-version: ${{ matrix.go }}

- name: Test
run: go test -race -v -tags '${{ matrix.tags }}' ./...
run: go test -race -v -tags '${{ matrix.tags }}' -shuffle=on ./...
if: runner.os != 'Windows'

- name: Test (without race detector)
run: go test -v -tags '${{ matrix.tags }}' ./...
run: go test -v -tags '${{ matrix.tags }}' -shuffle=on ./...
if: runner.os == 'Windows'

lint:
Expand Down
1 change: 1 addition & 0 deletions flags_test.go
Expand Up @@ -9,6 +9,7 @@ import (
)

func TestBindFlagValueSet(t *testing.T) {
Reset()
flagSet := pflag.NewFlagSet("test", pflag.ContinueOnError)

testValues := map[string]*string{
Expand Down
7 changes: 7 additions & 0 deletions viper_test.go
Expand Up @@ -471,6 +471,7 @@ func TestReadInConfig(t *testing.T) {
}

func TestDefault(t *testing.T) {
Reset()
SetDefault("age", 45)
assert.Equal(t, 45, Get("age"))

Expand All @@ -485,6 +486,7 @@ func TestDefault(t *testing.T) {
}

func TestUnmarshaling(t *testing.T) {
Reset()
SetConfigType("yaml")
r := bytes.NewReader(yamlExample)

Expand Down Expand Up @@ -521,13 +523,16 @@ func TestDefaultPost(t *testing.T) {
}

func TestAliases(t *testing.T) {
initConfigs()
Set("age", 40)
RegisterAlias("years", "age")
assert.Equal(t, 40, Get("years"))
Set("years", 45)
assert.Equal(t, 45, Get("age"))
}

func TestAliasInConfigFile(t *testing.T) {
initConfigs()
// the config file specifies "beard". If we make this an alias for
// "hasbeard", we still want the old config file to work with beard.
RegisterAlias("beard", "hasbeard")
Expand Down Expand Up @@ -870,6 +875,7 @@ func TestRecursiveAliases(t *testing.T) {
}

func TestUnmarshal(t *testing.T) {
Reset()
SetDefault("port", 1313)
Set("name", "Steve")
Set("duration", "1s1ms")
Expand Down Expand Up @@ -1341,6 +1347,7 @@ func TestBindPFlagStringToInt(t *testing.T) {
}

func TestBoundCaseSensitivity(t *testing.T) {
initConfigs()
assert.Equal(t, "brown", Get("eyes"))

BindEnv("eYEs", "TURTLE_EYES")
Expand Down

0 comments on commit 3a23b80

Please sign in to comment.