address more code review comments

sphinx-doc · Dec 6, 2021 · 264051c · 264051c
1 parent 376e3a6
commit 264051c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/sphinx/builders/linkcheck.py b/sphinx/builders/linkcheck.py
@@ -551,6 +551,7 @@ def setup(app: Sphinx) -> Dict[str, Any]:
     app.add_post_transform(HyperlinkCollector)
 
     app.add_config_value('linkcheck_ignore', [], None)
+    app.add_config_value('linkcheck_exclude_documents', [], None)
     app.add_config_value('linkcheck_allowed_redirects', {}, None)
     app.add_config_value('linkcheck_auth', [], None)
     app.add_config_value('linkcheck_request_headers', {}, None)
@@ -561,7 +562,6 @@ def setup(app: Sphinx) -> Dict[str, Any]:
     # Anchors starting with ! are ignored since they are
     # commonly used for dynamic pages
     app.add_config_value('linkcheck_anchors_ignore', ["^!"], None)
-    app.add_config_value('linkcheck_exclude_documents', [], None)
     app.add_config_value('linkcheck_rate_limit_timeout', 300.0, None)
 
     app.add_event('linkcheck-process-uri')

diff --git a/tests/roots/test-linkcheck-documents_exclude/conf.py b/tests/roots/test-linkcheck-documents_exclude/conf.py
@@ -2,4 +2,4 @@
 linkcheck_exclude_documents = [
     '^broken_link$',
     'br[0-9]ken_link',
-]
+]
diff --git a/tests/test_build_linkcheck.py b/tests/test_build_linkcheck.py
@@ -634,4 +634,4 @@ def test_linkcheck_exclude_documents(app):
     with open(app.outdir / 'output.json') as fp:
         for record in fp:
             content = json.loads(record)
-            assert content['status'] == 'unchecked'
+            assert content['status'] == 'ignored'