Respond to feedback

sphinx-doc · Jul 18, 2021 · 451811c · 451811c
1 parent 31e07c7
commit 451811c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/sphinx/util/typing.py b/sphinx/util/typing.py
@@ -312,7 +312,8 @@ def stringify(annotation: Any) -> str:
           hasattr(annotation, '__qualname__')):
         if hasattr(annotation, '__args__'):  # PEP 585 generic
             return repr(annotation)
-        return annotation.__qualname__
+        else:
+            return annotation.__qualname__
     elif annotation is Ellipsis:
         return '...'
 

diff --git a/tests/test_util_typing.py b/tests/test_util_typing.py
@@ -175,6 +175,18 @@ def test_stringify_type_hints_containers():
     assert stringify(Generator[None, None, None]) == "Generator[None, None, None]"
 
 
+@pytest.mark.skipif(sys.version_info < (3, 9), reason='python 3.9+ is required.')
+def test_stringify_type_hints_pep_585():
+    assert stringify(list[int]) == "list[int]"
+    assert stringify(list[str]) == "list[str]"
+    assert stringify(dict[str, float]) == "dict[str, float]"
+    assert stringify(tuple[str, str, str]) == "tuple[str, str, str]"
+    assert stringify(tuple[str, ...]) == "tuple[str, ...]"
+    assert stringify(tuple[()]) == "tuple[()]"
+    assert stringify(list[dict[str, tuple]]) == "list[dict[str, tuple]]"
+    assert stringify(type[int]) == "type[int]"
+
+
 @pytest.mark.skipif(sys.version_info < (3, 9), reason='python 3.9+ is required.')
 def test_stringify_Annotated():
     from typing import Annotated  # type: ignore