Escape image filenames

Without this change, local images with `#` in their name result in incorrect URLs There is already a similar call to `urllib.parse.quote` for file downloads, suggesting this is a sensible approach.
sphinx-doc · Mar 16, 2022 · 68ef3ed · 68ef3ed
1 parent 37e8967
commit 68ef3ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sphinx/writers/html.py b/sphinx/writers/html.py
@@ -612,7 +612,7 @@ def visit_image(self, node: Element) -> None:
         # rewrite the URI if the environment knows about it
         if olduri in self.builder.images:
             node['uri'] = posixpath.join(self.builder.imgpath,
-                                         self.builder.images[olduri])
+                                         urllib.parse.quote(self.builder.images[olduri]))
 
         if 'scale' in node:
             # Try to figure out image height and width.  Docutils does that too,

diff --git a/sphinx/writers/html5.py b/sphinx/writers/html5.py
@@ -560,7 +560,7 @@ def visit_image(self, node: Element) -> None:
         # rewrite the URI if the environment knows about it
         if olduri in self.builder.images:
             node['uri'] = posixpath.join(self.builder.imgpath,
-                                         self.builder.images[olduri])
+                                         urllib.parse.quote(self.builder.images[olduri]))
 
         if 'scale' in node:
             # Try to figure out image height and width.  Docutils does that too,