Skip imgconverter availability check if builder supports the image type #8649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close sphinx-doc#7973: ImgConverter runs is_available in HTML builder Close missinglinkelectronics/sphinxcontrib-svg2pdfconverter#8: Extension should only run on LaTeX builder
|
Just a small typo. It skips the availability check if the builder is not supported |
|
@Daltz333 Depends on what abstraction level you look at it ;-) The commit itself skips the imgconverter availability check if the builder supports the image type. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Skip imgconverter availability check if builder supports the image type
Feature or Bugfix
Purpose
Pull request #7978 fixed calling the imgconverter
is_availabality()function many times; however, the availability is currently still checked even if the builder supports the image type.Relates