Remove the build_sphinx command #10008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
approved these changes
Dec 23, 2021
| @@ -85,7 +85,7 @@ description = | |||
| extras = | |||
| docs | |||
| commands = | |||
| python setup.py build_sphinx {posargs} | |||
| sphinx-build docs/ docs/_build/ -W {posargs} | |||
There was a problem hiding this comment.
Suggested change
| sphinx-build docs/ docs/_build/ -W {posargs} | |
| sphinx-build docs/ docs/_build/ -W --keep-going {posargs} |
|
As I commented in #9595, we have to obey to our application policy. So we should emit a warning first for users to let users know the deprecation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Drop the distutils
build_sphinxcommandFeature or Bugfix
Purpose
Detail
sphinx.setup_commandand all direct references to it.Relates
#9595