Fix #10057: Failed to scan documents on the root directory #10068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
10057_scanning_docs_on_root
branch
from
1190a8e
to
5838017
Compare
get_matching_files() incorrectly drops the first character of each path on scanning documents. It will help users to exclude paths via exclude_patterns setting. Note: Users need to configure `exclude_patterns` to put their document on the root directory. This does not help to avoid recursive symlinks (ex. /proc, /sys)
tk0miya
force-pushed
the
10057_scanning_docs_on_root
branch
from
5838017
to
ce99cd4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
path on scanning documents. It will help users to exclude paths
via exclude_patterns setting.
exclude_patternsto put their documenton the root directory. This does not help to avoid recursive symlinks
(ex. /proc, /sys)