Fix #10058: autosummary: Imported members are not shown #10085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, the `check_module()` call was added at 21b8384 to hide imported members on generating stubs. But it was incorrect approach. Therefore it was disabled by b433197 and fixed the original issue by another approach at 2390c55. Finally, the `check_module()` call becomes meaningless code. But, at present, it causes that imported members are not shown when `autodoc_class_signature` is 'separated'. To resolve the problem, this removes the meaningless call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
check_module()call was added at 21b8384 to hideimported members on generating stubs. But it was incorrect approach.
Therefore it was disabled by b433197 and fixed the original issue by
another approach at 2390c55.
check_module()call becomes meaningless code. But, atpresent, it causes that imported members are not shown when
autodoc_class_signatureis 'separated'. To resolve the problem, thisremoves the meaningless call.
autodoc_class_signature='separated'. #10060