Skip "data:" URIs in ImageConverter #10099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2022
|
Thanks! |
tk0miya
added a commit
that referenced
this pull request
Jan 15, 2022
This was referenced Jan 16, 2022
|
For the record: I'm suggesting to revert this and solve it more generally in #10118. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10073.
Supersedes and closes #10074.
This alternative has been suggested by @tk0miya in #10073 (comment).
If a builder supports "data" URIs, we should assume that it supports all possible MIME types.
Using a "data" URI with an exotic image format doesn't really make sense.
Feature or Bugfix