Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing duplicate search results bug (5.0) #10236

Merged
merged 2 commits into from Mar 6, 2022
Merged

Fixing duplicate search results bug (5.0) #10236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a8744
fixing duplicate search results bug
calebchiam Mar 5, 2022
ca0d432
Merge branch 'sphinx-doc:master' into master
calebchiam Mar 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions sphinx/themes/basic/static/searchtools.js
View file
Open in desktop
Expand Up @@ -292,6 +292,20 @@ const Search = {
return leftScore > rightScore ? 1 : -1;
});

// remove duplicate search results
// note the reversing of results, so that in the case of duplicates, the highest-scoring entry is kept
let seen = new Set();
results = results.reverse().reduce((acc, result) => {
let resultStr = result.slice(0, 4).concat([result[5]]).map(v => String(v)).join(',');
if (!seen.has(resultStr)) {
acc.push(result);
seen.add(resultStr);
}
return acc;
}, []);

results = results.reverse();

// for debugging
//Search.lastresults = results.slice(); // a copy
// console.info("search results:", Search.lastresults);
Expand Down