Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URI-escape image filenames #10268

Merged
merged 23 commits into from Oct 13, 2022
Merged

URI-escape image filenames #10268

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
68ef3ed
Escape image filenames
eric-wieser Mar 16, 2022
8235359
half of a test...
eric-wieser Mar 20, 2022
7792ba9
Update test_build_html.py
eric-wieser Mar 20, 2022
4a9c806
Add files via upload
eric-wieser Mar 20, 2022
b0654bf
Fix broken testcases
tk0miya Mar 26, 2022
902d03f
show decoded error messages
eric-wieser Mar 26, 2022
85779c8
fix latex build
eric-wieser Mar 26, 2022
a029b83
try again
eric-wieser Mar 26, 2022
f66e81a
fix for real
eric-wieser Mar 26, 2022
1f82330
fix flake
eric-wieser Mar 26, 2022
d0fe52c
maybe?
eric-wieser Mar 26, 2022
78fd83a
Merge branch '5.x' into patch-5
AA-Turner Oct 5, 2022
69d338f
isort
AA-Turner Oct 5, 2022
9044afc
Merge branch '5.x' into escape-octothorpe
AA-Turner Oct 13, 2022
49d6a41
Fix matching
AA-Turner Oct 13, 2022
927ef07
Move to new test root
AA-Turner Oct 13, 2022
7f35307
Revert "Fix matching"
AA-Turner Oct 13, 2022
e2b2b0a
only run epubcheck
AA-Turner Oct 13, 2022
ccc4b96
Move to new test root
AA-Turner Oct 13, 2022
109e874
Revert "only run epubcheck"
AA-Turner Oct 13, 2022
a410042
ADD CHANGES entry
AA-Turner Oct 13, 2022
b85cecd
Test Env
AA-Turner Oct 13, 2022
052ac92
Update CHANGES
AA-Turner Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion sphinx/writers/html.py
View file
Open in desktop
Expand Up @@ -612,7 +612,7 @@ def visit_image(self, node: Element) -> None:
# rewrite the URI if the environment knows about it
if olduri in self.builder.images:
node['uri'] = posixpath.join(self.builder.imgpath,
self.builder.images[olduri])
urllib.parse.quote(self.builder.images[olduri]))

if 'scale' in node:
# Try to figure out image height and width. Docutils does that too,
Expand Down
2 changes: 1 addition & 1 deletion sphinx/writers/html5.py
View file
Open in desktop
Expand Up @@ -560,7 +560,7 @@ def visit_image(self, node: Element) -> None:
# rewrite the URI if the environment knows about it
if olduri in self.builder.images:
node['uri'] = posixpath.join(self.builder.imgpath,
self.builder.images[olduri])
urllib.parse.quote(self.builder.images[olduri]))

if 'scale' in node:
# Try to figure out image height and width. Docutils does that too,
Expand Down