Fix #10214: html: invalid language tag was generated for zh_CN #10311
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
force-pushed
the
10124_invalid_language_tag
branch
from
0920abf
to
db15908
Compare
So far, HTML builder output the `language` configuration as a language tag for HTML. But it takes locale string in ANSI C, not IETF language code. This converts locale string to language tag to generate valid language tag for HTML.
tk0miya
force-pushed
the
10124_invalid_language_tag
branch
from
db15908
to
11a1dbe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
languageconfiguration as a languagetag for HTML. But it takes locale string in ANSI C, not IETF language
code.
tag for HTML.