Only test with coverage on pushes to sphinx-doc/sphinx
#10361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
approved these changes
May 2, 2022
| @@ -47,8 +47,7 @@ | |||
| "types-requests", | |||
| ], | |||
| 'test': [ | |||
| 'pytest', | |||
| 'pytest-cov', | |||
| 'pytest>=4.6', | |||
There was a problem hiding this comment.
Note: pytest-4.6 has been packaged since Ubuntu 20.04. But I think it's okay because this dependency is for developers, not users.
| Ubuntu LTS | pytest version |
|---|---|
| 18.04 | 3.3.2 |
| 20.04 | 4.6.9 |
| 22.04 | 6.2.5 |
AA-Turner
force-pushed
the
split-coverage
branch
2 times, most recently
from
172061a
to
65ae948
Compare
Updated, I forgot that generators aren't reversible. Seems to be passing now. A |
|
Thank you for quick update. Merging now. |
|
@AA-Turner The coverage job was failed just after merging this. Could you check this, please? |
Merged
|
Was just working on that, please see #10413 -- sorry for the oversight. A |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up CI for PRs, this moves the coverage tests to only run on pushes to branches in this repo, rather than on forks and pull requests too.
I also bumped
pytestto 4.6 and removed some now-redundant code (we had previously always installedpytest-cov, which has requiredpytest>=4.6since 2020)https://github.com/pytest-dev/pytest-cov/blob/694f7fd497b07aaea76d96e484068faf440e8301/setup.py#L125
A
Feature or Bugfix
Relates