Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing problems raised in sphinx_issues #10104 #10379

Closed
wants to merge 2 commits into from

Commits on Apr 22, 2022

  1. Addressing problems raised in sphinx_issues sphinx-doc#10104

    hoangduytranuk committed Apr 22, 2022
    Configuration menu
    Copy the full SHA
    9fa160a View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Fixed the issue sphinx-doc#10104 after the code reviews from Adam Tur…

    …ner and Takeshi Komiya:
    
    - Added the class variable 'builder' to Catalog class, so any instances of Catalog can access the information within the builder, including things such as app, config, srcdir, outdir etc.. see MessageCatalogBuilder for details.
    - Initialise this Catalog.builder as the instance of MessageCatalogBuilder is created, ie. in the init()
    - As Message class is created, list of locations passing to it will be made singular, using set(), sorted alphabetically for easier searching and identifying origins where the message can be found.
    - source dir is used within the __iter__ of the Catalog, using sphinx.util.osutil.relpath, for safer functionality, to work out the relative path for each location entry.
    hoangduytranuk committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    ac71858 View commit details
    Browse the repository at this point in the history