Epub: Add WebP mime type #10443
Merged
Epub: Add WebP mime type #10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building docs with WebP images using the EPUB builder results in this warning: `WARNING: unknown mimetype for _images/<image_name>.webp, ignoring` This commit fixes this by adding the mapping for webp-files to the correct mime type.
|
This would need a test case, ideally. A |
tk0miya
requested changes
May 14, 2022
|
I think this is a data mapping. So testing is not needed. |
|
I was more thinking a simple regression test that WebP is accepted, rather than anything fancier. A |
|
+0 for adding a test. |
|
It seems 5.0.x branch is already broken (it contains a commit for 5.1). So I'll fix it after merging this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building docs with WebP images using the EPUB builder results in this warning:
WARNING: unknown mimetype for _images/<image_name>.webp, ignoringThis commit fixes this by adding the mapping for webp-files to the correct mime type.