Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9096: sphinx-build: the value of progress bar for paralle build is wrong #10454

Merged

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented May 15, 2022

Feature or Bugfix

  • Bugfix

Purpose

@tk0miya tk0miya added this to the 5.0.0 milestone May 15, 2022
@tk0miya tk0miya force-pushed the 9096_fix_progress_bar_on_parallel_build branch from 115b781 to 2b6aa4f Compare May 15, 2022 17:21
@tk0miya tk0miya force-pushed the 9096_fix_progress_bar_on_parallel_build branch from 2b6aa4f to facc890 Compare May 15, 2022 17:27
…lle build is wrong

The value of progress bar (reading and writing) should be increased just after
each task is finished.
@tk0miya tk0miya force-pushed the 9096_fix_progress_bar_on_parallel_build branch from facc890 to b78186d Compare May 15, 2022 17:33
Copy link
Contributor

@peterbell10 peterbell10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small copy-paste error, otherwise this looks good and I confirmed it fixes the issue.

sphinx/builders/__init__.py Outdated Show resolved Hide resolved
sphinx/builders/__init__.py Outdated Show resolved Hide resolved
sphinx/builders/__init__.py Outdated Show resolved Hide resolved
@tk0miya
Copy link
Member Author

tk0miya commented May 22, 2022

Thank you for your comments. Merging this now.

@tk0miya tk0miya merged commit 21df068 into sphinx-doc:5.0.x May 22, 2022
@tk0miya tk0miya deleted the 9096_fix_progress_bar_on_parallel_build branch May 22, 2022 06:39
@jeanas
Copy link
Contributor

jeanas commented May 22, 2022

Thank you for the fix!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants