Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sphinx-doc#10104: gettext: Duplicated locations are output to pot file #10466

Merged

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented May 22, 2022

Feature or Bugfix

  • Bugfix

Purpose

  • When 3rd party extension does not provide line number for each message,
    duplicated locations are output to pot file unexpectedly. This filters
    duplicated locations before generationg pot file.
  • gettext builder has already called relpath inside template. So I don't call it on this PR.
  • refs: Message.locations duplicate unnecessary #10104

@tk0miya tk0miya added this to the 5.0.0 milestone May 22, 2022
@tk0miya tk0miya force-pushed the 10104_gettext_duplicated_locations branch from 6853e58 to e3b7937 Compare May 22, 2022 16:47
@tk0miya tk0miya changed the title 10104 gettext duplicated locations Fix sphinx-doc#10104: gettext: Duplicated locations are output to pot file May 22, 2022
… file

When 3rd party extension does not provide line number for each message,
duplicated locations are output to pot file unexpectedly.  This filters
duplicated locations before generationg pot file.
@tk0miya tk0miya force-pushed the 10104_gettext_duplicated_locations branch from e3b7937 to 51c84e0 Compare May 22, 2022 16:50
@tk0miya tk0miya merged commit c28b464 into sphinx-doc:5.0.x May 26, 2022
@tk0miya tk0miya deleted the 10104_gettext_duplicated_locations branch May 26, 2022 00:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants