New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10594: HTML: field term colons are doubled if using Docutils 0.18+ #10595
Conversation
Thanks @jfbu! I suggested a couple of changes. Testing HTML output is a much bigger challenge in general, as it pretty much needs to be a visual comparison -- layered CSS files etc. can affect output with identical HTML content. A |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
ok thanks, applied. I see now that you had been defining and using About the change to CHANGES, I had noticed you used
Yes, understood, however I was surprised that we (I initially wrote "you" by mistake ;-) ) did not have a check which would have signaled html output (I mean the html files, not how they are rendered, and not even the CSS files) got modified by the upstream Docutils 0.18 changes. Visual comparison is imho simply not feasible and will always let things pass through. I apply it from time to time on our own docs |
I just use it as it seems to be the precedent for CSS changes etc.
Hmm, perhaps we can add such a thing. It is difficult to construct a short test file that hits all the various permutations of reST syntax, though. A |
Relates
The Docutils commit responsible for the change at 0.18 is rev8734
Nota bene:
<span class="colon">:</span>
at Docutils 0.18. As I am not competent enough to add a test conditional on Docutils version I did not (remember I am only LaTeX guru here).docinfo
class for<dl>
is not involved at Sphinx level