Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure for Docutils 0.18.0 #10597

Merged
merged 2 commits into from Jun 25, 2022

Conversation

jfbu
Copy link
Contributor

@jfbu jfbu commented Jun 25, 2022

Node.findall() was added only at Docutils 0.18.1, here is extract from Docutils HISTORY

Release 0.18.1
==============

* docutils/nodes.py

  - `Node.traverse()` returns a list again to restore backwards
    compatibility. Fixes bug #431.

  - New method `Node.findall()`: like `Node.traverse()` but returns an
    iterator. Obsoletes `Node.traverse()`.

Fix #10596

Relates

@jfbu jfbu added the type:bug label Jun 25, 2022
@jfbu jfbu added this to the 5.0.3 milestone Jun 25, 2022
@jfbu jfbu requested a review from tk0miya June 25, 2022 14:26
@jfbu jfbu changed the title Fix #10196: Build failure if Docutils version is 0.18 (not 0.18.1) Fix #10596: Build failure if Docutils version is 0.18 (not 0.18.1) Jun 25, 2022
…0.18.1)

Node.findall() was added only at Docutils 0.18.1
@AA-Turner AA-Turner changed the title Fix #10596: Build failure if Docutils version is 0.18 (not 0.18.1) Fix build failure for Docutils 0.18.0 Jun 25, 2022
@AA-Turner AA-Turner merged commit 5a24fec into sphinx-doc:5.0.x Jun 25, 2022
@jfbu jfbu deleted the 10596_Node_findall branch June 26, 2022 08:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants