Extend cross referencing options with values #10883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marxin
force-pushed
the
option-ref-optional-part
branch
2 times, most recently
from
de04e51
to
f0abef2
Compare
marxin
changed the title
|
What do you think @AA-Turner? |
marxin
force-pushed
the
option-ref-optional-part
branch
from
8e83d4d
to
0cd9f58
Compare
This supports a commonly used format when it comes to optional argument: -fauto-profile[=path], where `path` is optional part. Plus it supports a format when space is used: -fauto-profile path. Extends: sphinx-doc#10840 Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
marxin
force-pushed
the
option-ref-optional-part
branch
from
0cd9f58
to
861f1b7
Compare
|
@marxin please don't force push, it makes review much more difficult after leaving comments. A |
|
All right, so you prefer leaving there the "Suggested change" commits, right? |
|
Yes, I squash merge on commit. A |
AA-Turner
approved these changes
Oct 2, 2022
AA-Turner
changed the title
|
Thanks! A |
Makes sense, will do that next time. |
I thank you for a nice negotiation we made. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports a commonly used format when it comes to optional argument:
-fauto-profile[=path], wherepathis optional part. Plus it supports a format when space is used:-fauto-profile path.Extends: #10840