html builder omit query component when builder name start with 'epub' #11967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about builders that enhance EPUB but are not named like that? like |
|
Thank you for your response. I've thinked about your question, any choice will be embeding negative effects into the code base. withdrawing my PR is the best one. |
|
Oh, you did not need to do that actually. I don't think it would have been a bad idea to have a configuration value. Anyway, we can always reopen this PR if the needs arise ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject:
Feature or Bugfix
Purpose
PR #11766 removed query component from URLs in EPUB. But if we want enhance epub builder for their own needs, it doesn't work. This PR aim to solve this.
Detail
compare builder name start with 'epub' not fixed literal. we can use our own builder name with prefix 'epub'.
Relates
#11598