Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] add logic for testing sphinx.testing.fixtures [part 3] #12106

Open
wants to merge 103 commits into
base: master
Choose a base branch
from

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Mar 16, 2024

This follows #12093.

This adds the tests for testing our plugin implementation.

Due to xdist implementation, the collection of test items does not happen on the controller node but only at the level of the worker nodes and each worker node executes the same protocol.

Now, if a test is parametrized, it is obvious that we want the tests to be executed by the same worker, hence the needs of xdist_group. Unfortunately, you cannot specify the group at the moment a fixture is requested since it will already be too late. Thus, if no explicit group is given, we automatically add a group to parametrized tests based on the location of the "base" node.

Note that this feature only affects our internal tests, so downstream repos using the plugin are not affected and should do their own trick for xdist (they can use the same approach or do whatever they need manually).

@picnixz picnixz mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant