Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkcheck: Improve robustness during anchor checks #12197

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jayaddison
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Purpose

  • Improve robustness during anchor-checks, when the linkcheck decodes response content.
  • Begin to add more validation of parsed HTML.

Detail

  • Do not attempt to check for anchors when UTF8 decoding fails; report affected hyperlinks as ignored.
  • Report hyperlinks as broken when their content fails validation checks, but allow this to be overridden using URI-match patterns.

Relates

@AA-Turner AA-Turner changed the title [linkcheck] Add additional anchor-checking safety checks. linkcheck: Improve robustness during anchor checks Apr 24, 2024
@jayaddison
Copy link
Contributor Author

@AA-Turner is it OK if we pause on this one for a while? I think/hope it's a good idea, but I'm slightly concerned that the distinction between lenient and strict parsing might be a bit arbitrary. I should perhaps move this back into a draft status.

@AA-Turner AA-Turner marked this pull request as draft April 24, 2024 18:50
@jayaddison
Copy link
Contributor Author

Another way to phrase that: I'd like to canvas more (and perhaps leaning skeptical) opinions about this before proceeding.

@jayaddison
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linkcheck] PDF anchor (...pdf#anchor) leads to 'utf-8' codec can't decode byte ...
2 participants