Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8872: autodoc: stacked singledispatches are wrongly rendered #9157

Merged
merged 1 commit into from May 3, 2021

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented May 2, 2021

Feature or Bugfix

  • Bugfix

Purpose

@tk0miya tk0miya added this to the 4.1.0 milestone May 2, 2021
@tk0miya tk0miya force-pushed the 8872_stacked_singledispatch branch 2 times, most recently from 9bb1de0 to 8d86d35 Compare May 2, 2021 14:40
…ndered

When multiple singledispatch decorators are stacked, the first typehints
are copied to the subsequent definitions unexpectedly.

Now autodoc generates a dummy function not to affect typehints to
subsequent functions.
@tk0miya tk0miya force-pushed the 8872_stacked_singledispatch branch from 8d86d35 to caa6579 Compare May 3, 2021 12:51
@tk0miya tk0miya merged commit cb7b41f into sphinx-doc:4.x May 3, 2021
@tk0miya tk0miya deleted the 8872_stacked_singledispatch branch May 3, 2021 13:10
@anntzer
Copy link
Contributor

anntzer commented May 3, 2021

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants