Add tests for dataclasses: autodoc and autosummary #9236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel no additional tests are needed for dataclasses. The mechanism is the same as the instance attributes annotations. Note: I think the testcases for namedtuple is also not needed by the same reason. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Add tests with dataclasses
This PR is a continuation to #9146 where support for instance attributes in
autosummarywas added. As Phil correctly pointed out this change also fixes generated content fordataclasses. This change was hard to notice because there were no unit tests includingdataclassespresent. Asdataclassesbecame somehow standard thing for python >= 3.7 I believe it's a good idea to test if content generated for them is correct.Feature or Bugfix
Purpose
Relates