New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide more semantic structure for screen-readers #9358
Conversation
Looks like Lines 625 to 626 in 13d59bc
|
@astrojuanlu thanks for the tip, I updated the test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonels-msft !
@astrojuanlu cool, do we need someone else to review too, or is this good to merge? |
@jonels-msft this looks good to me but a Sphinx maintainer needs to review it. Also, someone has to approve the pipelines to run, to verify that we are not missing anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late. LGTM!
Merged. Thank you for your contribution! |
Subject: Fix menu narration for sceen-readers
Feature or Bugfix
Accessibility bugfix
Purpose
The use of
<p>
for submenu captions lacks semantic information. Screen-readers don't narrate the menu correctly. This PR adds role="heading" to the caption as an ARIA landmark.Detail
I don't yet know how to test my changes locally, so there may be errors. Please advise if I got it wrong.
Relates
Fixes #8989
Accessibility technique described in https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA12