Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xeCJKVerbAddon to default fvset config for Chinese documents #9419

Merged
merged 1 commit into from Jul 10, 2021

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Jul 7, 2021

Feature or Bugfix

  • Bugfix

Purpose

Fixes: #9414

cc @stone-zeng @muzimuzhi

@tk0miya
Copy link
Member

tk0miya commented Jul 8, 2021

Is this fix a temporary workaround or a configuration? I'd like to know we can remove this setting in the future or not.

Additionally, it would be better to add a comment on what this setting doing to maintain the code.

@zhsj
Copy link
Contributor Author

zhsj commented Jul 8, 2021

Is this fix a temporary workaround or a configuration? I'd like to know we can remove this setting in the future or not.

This is an old issue in xeCJK, which backs to 2017 (CTeX-org/ctex-kit#331). It's not easy to fix on xeCJK, as fancyvrb is not in kernel(not sure the translation, I don't know what's that mean, but it's said in xeCJK issue, in Chinese.) Maybe @stone-zeng(xeCJK maintainer) can add some context here.

This is a configuration which proposed by @stone-zeng in #9414 (comment)

@zhsj
Copy link
Contributor Author

zhsj commented Jul 8, 2021

Additionally, it would be better to add a comment on what this setting doing to maintain the code.

done

Prevent xeCJK from adding extra spaces in fancyvrb Verbatim enviroment.

Fixes: sphinx-doc#9414

Signed-off-by: Shengjing Zhu <i@zhsj.me>
@stone-zeng
Copy link

We may not patch fancyvrb packages etc in xeCJK recently, and even if the patch is added in the future, the settings here will still not be affected. So I think this pr is ok.

@tk0miya
Copy link
Member

tk0miya commented Jul 10, 2021

Thank you for explanation. Merging now.

@tk0miya tk0miya merged commit 7e3e152 into sphinx-doc:4.x Jul 10, 2021
tk0miya added a commit that referenced this pull request Jul 10, 2021
@zhsj zhsj deleted the fancyvrb-zh branch July 10, 2021 18:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CJK render issue in latexpdf code block
4 participants