Always cast the special_members as a list #9472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unclear from the context if `special_members` should be a list or a set - just go with the list
|
@tk0miya I can no longer leave comments on #4257 for some reason (not sure, why did GitHub even allow me to open that code review in the first place 😅). Also, I didn't notice that somebody already reported this issue, when I was writing that comment, sorry for the confusion. Not sure, if the |
|
Oops... list should be used for this case. So set is invalid. |
|
Merged #9493 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for
#9471
#9436
Autodoc is mixing
setandlisttypes for the sameself.options.special_membersvariable.However because the original code is not typed, it is hard to deduct from the context if the fix is "correct" or "clean". I suggest some of the original authors review the fix.