Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autodoc] Fix uncatched exception in get type hints #9509

Merged
merged 2 commits into from Jul 30, 2021
Merged

[autodoc] Fix uncatched exception in get type hints #9509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67fb3d1
Fix uncatched exception in get type hints
yanyongyu Jul 29, 2021
4cceeae
Merge branch '4.x' into bugfix/get-type-hints
yanyongyu Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions sphinx/util/typing.py
View file
Open in desktop
Expand Up @@ -86,6 +86,9 @@ def get_type_hints(obj: Any, globalns: Dict = None, localns: Dict = None) -> Dic
except NameError:
# Failed to evaluate ForwardRef (maybe TYPE_CHECKING)
return safe_getattr(obj, '__annotations__', {})
except AttributeError:
# Failed to evaluate ForwardRef (maybe not runtime checkable)
return safe_getattr(obj, '__annotations__', {})
except TypeError:
# Invalid object is given. But try to get __annotations__ as a fallback for
# the code using type union operator (PEP 604) in python 3.9 or below.
Expand Down