Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9504: autodoc: generate incorrect reference to the parent class #9515

Merged
merged 1 commit into from Aug 1, 2021

Conversation

tk0miya
Copy link
Member

@tk0miya tk0miya commented Jul 30, 2021

Feature or Bugfix

  • Bugfix

Purpose

  • Autodoc generates incorrect references to the parent class the target
    class inherites the class having _name attribute. It conciders the
    parent is a kind of SpecialForm'ed class by mistake. This uses
    isinstance(X, SpecialForm) to check that.
  • Note: SpecialForm became a class since Python 3.7.
  • refs: Sphinx 4.1.2 breaks base class detection #9504

…ent class

Autodoc generates incorrect references to the parent class the target
class inherites the class having `_name` attribute.  It conciders the
parent is a kind of SpecialForm'ed class by mistake.  This uses
`isinstance(X, SpecialForm)` to check that.

Note: SpecialForm became a class since Python 3.7.
@tk0miya tk0miya added this to the 4.1.3 milestone Jul 30, 2021
@tk0miya tk0miya merged commit 650730d into sphinx-doc:4.1.x Aug 1, 2021
@tk0miya tk0miya deleted the 9504_SpecialForm branch August 1, 2021 06:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant