Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

themes: use noscript for search js notification #9617

Closed
wants to merge 1 commit into from
Closed

themes: use noscript for search js notification #9617

wants to merge 1 commit into from

Commits on Sep 7, 2021

  1. themes: use noscript for search js notification 

    The "search.html" template will generate a warning admonition about
requiring JavaScript for search and automatically hiding the element
when supported. While functional, if a client renders the page slowly,
the warning notification may be visible to the user for a moment.

Instead of relying on JavaScript to suppress this warning, use a
`noscript` tag to hide the warning for clients who do not support
JavaScript. This also has the benefit of one less JavaScript call
required by a client.

Signed-off-by: James Knight <james.d.knight@live.com>
    @jdknight
    jdknight committed Sep 7, 2021
    Copy the full SHA
    3d54d36 View commit details
    Browse the repository at this point in the history