Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sphinx tutorial, part IV #9852

Merged
merged 9 commits into from Dec 4, 2021

Conversation

astrojuanlu
Copy link
Contributor

@astrojuanlu astrojuanlu commented Nov 15, 2021

Feature or Bugfix

  • Feature

Purpose

This is a continuation of the work we did in #9276, #9355, and #9534. It expands some sections already started in the first part and adds some new ones, as originally proposed in #9165:

  1. Deploying a Sphinx project online

I ended up renaming it to an "Appendix", because it is more of a how-to guide rather than a tutorial.

Relates

@astrojuanlu astrojuanlu force-pushed the new-tutorial-deploying branch 2 times, most recently from d399a7a to 9447dfa Compare November 17, 2021 20:00
Copy link

@muraad33 muraad33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<0>

@astrojuanlu astrojuanlu changed the title WIP: New Sphinx tutorial, part IV New Sphinx tutorial, part IV Nov 18, 2021
@astrojuanlu astrojuanlu marked this pull request as ready for review November 18, 2021 14:59
@astrojuanlu
Copy link
Contributor Author

Surprisingly, it took me some time to find an appropriate workflow for GitHub Pages, but it's ready. This is ready for review - if I have some extra time today, I will add a couple more deployment methods.

@astrojuanlu
Copy link
Contributor Author

I'm done 🏁 I have zero familiarity with Netlify and I have already spent a good chunk of time getting this out (plus it's quite long and dense already), so I'm going to leave the door open for folks to document more methods.

@astrojuanlu
Copy link
Contributor Author

Copy link
Member

@tk0miya tk0miya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits!

doc/tutorial/deploying.rst Show resolved Hide resolved
@tk0miya tk0miya added type:docs type:enhancement enhance or introduce a new feature labels Nov 23, 2021
@tk0miya tk0miya added this to the 4.4.0 milestone Nov 23, 2021
@tk0miya
Copy link
Member

tk0miya commented Dec 4, 2021

It seems no new review comments. It's time to merge!

@tk0miya tk0miya merged commit 86639b7 into sphinx-doc:4.x Dec 4, 2021
@tk0miya
Copy link
Member

tk0miya commented Dec 4, 2021

Merged. Thank you for your contribution as always!

@astrojuanlu astrojuanlu deleted the new-tutorial-deploying branch December 4, 2021 06:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:docs type:enhancement enhance or introduce a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants