BUG: prevent automatic inline conversion by class #9873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
reviewed
Nov 21, 2021
|
I think this is a critical bug. So could you rebase this into the 4.3.x branch? Then I'll release a new package including this fix as 4.3.1 soon. |
|
@tk0miya thanks for the review! I'll update to a class-var and rebase first thing Monday :) |
ebolyen
force-pushed
the
docutils-auto-convert
branch
from
b28945c
to
c947bbf
Compare
|
@tk0miya ready for re-review, thanks! |
|
Just kidding... |
ebolyen
force-pushed
the
docutils-auto-convert
branch
from
c947bbf
to
836324b
Compare
|
Ok, copy-paste error fixed. All set. |
|
Merged. Thank you for your contribution! |
tk0miya
added a commit
that referenced
this pull request
Nov 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
To prevent inline nodes from being automatically coerced into specific HTML 5 elements.
This was a new feature added in docutils 0.17 and conflicts with some of the short class names added in #9023, namely "s" which is automatically coerced into a strike-through element.
Relates
See #9872 for motivation.
This is largely a drive-by effort. I don't know if this is the way you all would prefer to solve this, but I was able to get it working, and it seems like a very mild change. No hard feelings if this isn't the way you want to go.