Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add show_code_download conf.py option #1070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LuisBL
Copy link

@LuisBL LuisBL commented Jan 21, 2023

Related to #1069

provide a show_code_download key to conf.py, if False do not expose "Download Python source code" neither Jupyter notebook

@larsoner
Copy link
Contributor

See #949, I think we've decided this is not necessary

@SimenZhor
Copy link

@larsoner as a user I think it would be a lot more convenient to have this as an option in conf.py rather than having to make custom css rules to hide the buttons. Especially as that would eliminate the need for uploading the _downloads folder to my host (this PR should probably make sure that folder does not be generated in the first place).

@larsoner
Copy link
Contributor

larsoner commented Mar 8, 2023

@lucyleeow WDYT?

@lucyleeow
Copy link
Contributor

I understand it would be easier to users but I am reluctant to add to our already large list of config options (though it probably doesn't add much maintenance).
How about adding a part to our documentation about how to hide this via CSS? Maybe expanding the section 'And some things can be tweaked directly in CSS:' (here). I vaguely recall a few issues about other things that can be tweaked via CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants