Pin numpy<1.24 to mitigate incompatibility with pystrum==0.2
#3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuacwnewton
added
bug
mguaypaq
approved these changes
Dec 20, 2022
joshuacwnewton
deleted the
jn/3980-downgrade-numpy-to-fix-pystrum-incompatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Numpy 1.24 was released recently, bringing with it the removal of the
np.boolalias.One of our upstream dependencies,
voxelmorph, depends onneurite, which in turn depends onpystrum. Pystrum's most recent PyPI version still usesnp.bool. (See adalca/pystrum#9.)Until
pystrumfixes this issue, we can pinnumpy<1.24to keep our test suite from failing.Linked issues
Fixes #3980.