fix(cve): Update snakeyml to 1.31 to fix following CVEs CVE-2022-25857 CVE-2022-38749 #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbyron-sf
requested changes
Mar 5, 2024
There was a problem hiding this comment.
I'd rather not do this yet. Although it may be working, until we have spring-projects/spring-boot#32228 which comes with spring boot 2.6.12, I feel like we're exposing ourselves to a potential bug when some user has some unexpected thing in a spinnaker config file.
We're quite close to merging #1134 and going to spring boot 2.6.15. Can we wait for that?
|
handled by #1173. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested this in our Harness internal environments for some time and have not seen any misbehavior.