Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for python 3.10 #921

Merged
merged 6 commits into from Nov 15, 2021
Merged

Conversation

Glandos
Copy link
Member

@Glandos Glandos commented Nov 15, 2021

No description provided.

@Glandos
Copy link
Member Author

Glandos commented Nov 15, 2021

For Python 3.10, pytest needs pytest-dev/pytest#8540 that was backported in pytest-dev/pytest#8629 And anyway, official support for Python 3.10 is in pytest-dev/pytest#8494 that was released in pytest 6.2.5

We are currently on >=5.4.1. I'm not against a switch to 6.2.5. But I need opinions on this. pytest 6.2.5 is already installed on "normal" tests, so everything runs fine on this.

@zorun
Copy link
Collaborator

zorun commented Nov 15, 2021

We currently claim to support Python 3.6 to 3.9, so if the new version of pytest works on Python 3.6, go for it!

@Glandos
Copy link
Member Author

Glandos commented Nov 15, 2021

@zorun commented on 15 nov. 2021, 21:54 UTC+1:

We currently claim to support Python 3.6 to 3.9, so if the new version of pytest works on Python 3.6, go for it!

Yes, Python 3.6 was the minimal requirement updated in pytest 6.2.0

@Glandos Glandos merged commit 4d6a5aa into spiral-project:master Nov 15, 2021
@Glandos Glandos deleted the python3.10 branch November 15, 2021 21:33
@Glandos Glandos mentioned this pull request Nov 15, 2021
TomRoussel pushed a commit to TomRoussel/ihatemoney that referenced this pull request Mar 2, 2024
This also raises pytest and flask-cors version to work with python 3.10. Changes are non invasive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants