Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using PostgreSQL with docker image #927

Closed
wants to merge 2 commits into from
Closed

Allow using PostgreSQL with docker image #927

wants to merge 2 commits into from

Conversation

Nikos410
Copy link
Contributor

Install psycopg2, which is needed to access a PostgreSQL database.

Resolves #924

@Nikos410 Nikos410 changed the title Install psycopg2 in docker image Allow using PostgreSQL with docker image Nov 21, 2021
@zorun
Copy link
Collaborator

zorun commented Nov 21, 2021

Thanks for the patch. Can you measure the additional time needed to build the image? And the resulting size increase? If the size increases a lot, we might want to simply use a debian-based image and install the binary psycopg2 package (see #924)

Also, the doc mentions that the docker image does not support postgresql, it needs to be updated :)

@Nikos410
Copy link
Contributor Author

Will do :)

@Nikos410 Nikos410 marked this pull request as draft November 21, 2021 21:44
@Nikos410
Copy link
Contributor Author

See #924 (comment)

@Nikos410
Copy link
Contributor Author

Superseded by #919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using docker image with postgres
2 participants