Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove default webpack licenses #1184

Closed
wants to merge 1 commit into from

Conversation

soleksy-splunk
Copy link
Contributor

Removing default webpack licenses that creates files with extensions .js.LICENSE.txt

@vtsvetkov-splunk
Copy link
Collaborator

Is that ok from legal perspective?

@soleksy-splunk
Copy link
Contributor Author

Is that ok from legal perspective?

thats the problem that we do not know,
i created it when doing some cleaning
and figured out we got 2 licenses files

  1. default from webpack
  2. second one added from webpack plugin

so removed 1st one as it looked much smaller and not for every file, but it is not that good 'win' as those files were very small ones, so probably branch to be closed and picked up when licensing will become issue.

@soleksy-splunk
Copy link
Contributor Author

It is not providing enough benefit

@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants