fix: Disable access to external entities in XML parsing #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrawnCA
approved these changes
Oct 16, 2022
KengoTODA
requested changes
Oct 17, 2022
| try { | ||
| reader.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true); | ||
| } catch (Exception e) { | ||
| throw new IllegalArgumentException(e); |
There was a problem hiding this comment.
It seems that it's not argument issue (this buildSAXReader() method has no argument).
It is probably better to use another exception type?
There was a problem hiding this comment.
I have modified the exception type and added an error message, please let me know if you had something else in mind or if this requires further adjustments
| factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_DTD, ""); | ||
| factory.setAttribute(XMLConstants.ACCESS_EXTERNAL_STYLESHEET, ""); | ||
| } catch (Exception e) { | ||
| throw new IllegalArgumentException(e); |
ThrawnCA
approved these changes
Oct 19, 2022
KengoTODA
reviewed
Oct 23, 2022
gtoison
force-pushed
the
disable-access-to-external-entities
branch
from
2ff2de8
to
4c3481c
Compare
|
Thanks for the review, I have rebased and added a security category in the changelog with a new entry for this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes security issues detected by sonarcloud such as: https://sonarcloud.io/project/issues?issues=AXDRMcroPCexr-BXKaE_&open=AXDRMcroPCexr-BXKaE_&id=com.github.spotbugs.spotbugs
Added methods in
XMLUtilto setup XML objects with more secure options